Review archshrk.com

[archshrk]

The site is a personal website using Wordpress and Gallery2.
I've been working with the css files and am pretty sure it all works the way I intended, however...Since not all browsers are equal and not all visitors have the same opinions...I ask that you please review my site archshrk.com (http://archshrk.com)

Be sure to include your thoughts on the gallery (http://archshrk.com/wp-gallery2.php), as the seamless integration of the main site (blog) and gallery is a very high priority. Thanks.

[PsychoticDude85]

I like it, it loads a little slow for me, but that's probably bandwidth on my end.

The code is a bit dodgy on the other hand, the CSS is good but could do with removing those warnings:
http://jigsaw.w3.org/css-validator/validator?profile=css2&warning=2&uri=http://archshrk.com/wp-content/themes/treacle/style.css

Line : 33 (Level : 2) Redefinition of padding-bottom : #header
Easy, change the top padding-bottom delete the redefinition.
Line : 60 (Level : 1) You have no background-color with your color :
Just add background-color: inherit; under the color:
Line : 86 (Level : 1) Same colors for color and background-color in two contexts
Just change it by one :P if it's #000 change it to #010101;
Line : 134 (Level : 1) You have no color with your background-color
Add a text colour :)

And that would be all of those warnings gone and forgotten.

The xhtml is a bit dodgy, " Failed validation, 43 errors" (not good), but I can sympathise that this is largely the CMS you are running and you may not yet be fluent enough in php to correct it.

Anyway, definate congratulations are in order, a very nice site!

[archshrk]

Thanks, I wish I could take more credit for it. The xhtml issues are more technical than legitimate (does that make sense?) Anyway, it's a know issue that can not be resolved right now. As for the css errors, do I need to add background-color: inherit; to all my defenitions? Seems to go against the whole idea of css. Also, I can't find the redefenition mentioned hereLine : 33 (Level : 2) Redefinition of padding-bottom : #header
Easy, change the top padding-bottom delete the redefinition.
Thanks for the feedback so far. I love learning this stuff hands-on and making the unseen improvements as well as those everyone sees. Keep it comming.

[PsychoticDude85]

You need only add it to those with the color: attribute (this is a recent developement in CSS validation).

As to the padding, change:

#header /* where your blog title and description live */{

background:url('images/squares.gif') bottom left repeat-x;

padding:10px;

padding-bottom:40px;

text-align:right}
into

#header /* where your blog title and description live */ {
background:url('images/squares.gif') bottom left repeat-x;
padding:10px 10px 40px 10px;
text-align:right
}

[archshrk]

Oh, that makes sense.
Now this is confussing me
Line : 142 (Level : 1) You have no color with your background-color : #comment
Line : 142 (Level : 1) You have no color with your background-color : #comment
Line : 142 (Level : 2) Redefinition of background-color : #comment
How can it not be there and have a redefinition? I'm sure I'm just missing something easy but I can't seem to see it. This is an example of my remaining errors.

[ruth]

It wants a color:#whatever on the 142 #comment. Not sure on the other, unless it has to do with background-color:inherit when you have background:#xxxxxx right above it.

[archshrk]

These warnings are still making my head hurt. Can someone explain what I'm doing wrong here?
http://jigsaw.w3.org/css-validator/validator?profile=css2&warning=2&uri=http://archshrk.com/wp-content/themes/treacle/style.css

[Terminator1138]

Your css does validate at least It worked for me...however your xml does not or you need to work on validating that first to validate directly from your site..

[ruth]

Among all the other zillions of things the w3c says you should do with regard to using css styles is if you use background-color: code you should also have color: code. So, if everyplace you have a warning that says You have no color with your background-color, if you add the css code for font color, color: #xxxxxx; you will probably eliminate those warnings.

As to the redefinition of background-color, in all the places I see that warning you have coded a background color and then you have put in background-color:inherit, so I have to think that is the problem.

As to the redefintion of border-left-color and border-bottom-color, that is problably because you have border:1px solid #xxxxxxx; so maybe they want you to not use that use the full border-left:whatever;border-right: ; and so on. The same thing happens with the margin you have margin:0 and then margin-top: 15px; They probably want something like margin-top:15px;margin-left:0px and so on, or margin:15px 0px 0px 0px;

Ruth

[archshrk]

Thank you Ruth! between the earlier posts and your comments I was able to get it all worked out. No errors, no warnings. I am a very happy camper now.

[archshrk]

NEW PROBLEM:
I am using a bit of code from a third party and find that there is extra "white space" around the table that should not be there. Any ideas why this is happening?

sample page: http://archshrk.com/2006/01/a-poll-about-heaven/

[ruth]

The div on the page in the iframe is width: 200px; height: 245px; but the iframe is width=212 height=257 so the page aligns left and you get the extra space. Change the iframe width to match what's on that poll.php page

[archshrk]

Perfect! I figure that's what it was but the numbers started to blur together.

[archshrk]

I've upgraded and added some new features (like amazon's aStore (http://archshrk.com/the-company-store/)) and tried to clean up some of the fluff. Check out the integrated google search and gallery2 install.

[Terminator1138]

Hi, This post is very informative, however I would like some specific information. If someone can help me then please send me a private message. Best Regards,
ummm, like the posts state, its a review,

[archshrk]

I'm having a problem with the new design.
I included this in my style.css but it doesn't work.
a:link img {
border-style : none;
It should remove the link border from around my images but it still shows up. Any ideas?

[PsychoticDude85]

I would personally use this:
a img { border: 0; }

[archshrk]

That seems to have done it. Thanks.

[intiendes]

HTML Validation Result
----------------------
http://archshrk.com/

line 4 column 1 - Warning: <a> isn't allowed in <head> elements
line 17 column 1 - Warning: <link> isn't allowed in <body> elements
line 17 column 1 - Warning: <style> isn't allowed in <body> elements
line 17 column 1 - Warning: <style> isn't allowed in <body> elements
line 17 column 1 - Warning: </head> isn't allowed in <body> elements
line 62 column 1 - Warning: discarding unexpected <body>
line 119 column 1 - Warning: missing </ul> before </li>
line 73 column 1 - Warning: missing </div> before <li>
line 131 column 1 - Warning: inserting implicit <ul>
line 183 column 1 - Warning: <link> isn't allowed in <li> elements
line 262 column 1 - Warning: discarding unexpected </li>
line 264 column 1 - Warning: missing <li>
line 275 column 1 - Warning: missing </a> before <h3>
line 275 column 168 - Warning: inserting implicit <a>
line 298 column 1 - Warning: <br> element not empty or not closed
line 326 column 1 - Warning: missing </a> before <h3>
line 326 column 185 - Warning: inserting implicit <a>
line 344 column 1 - Warning: <br> element not empty or not closed
line 367 column 1 - Warning: missing </a> before <h3>
line 367 column 173 - Warning: inserting implicit <a>
line 382 column 1 - Warning: replacing <p> by <br>
line 382 column 1 - Warning: inserting implicit <br>
line 382 column 1 - Warning: <br> element not empty or not closed
line 390 column 1 - Warning: <br> element not empty or not closed
line 413 column 1 - Warning: missing </a> before <h3>
line 413 column 149 - Warning: inserting implicit <a>
line 433 column 1 - Warning: <br> element not empty or not closed
line 456 column 1 - Warning: missing </a> before <h3>
line 456 column 139 - Warning: inserting implicit <a>
line 481 column 1 - Warning: <br> element not empty or not closed
line 504 column 1 - Warning: missing </a> before <h3>
line 504 column 139 - Warning: inserting implicit <a>
line 523 column 1 - Warning: <br> element not empty or not closed
line 546 column 1 - Warning: missing </a> before <h3>
line 546 column 195 - Warning: inserting implicit <a>
line 555 column 76 - Warning: discarding unexpected </param>
line 555 column 84 - Warning: <embed> is not approved by W3C
line 557 column 1 - Warning: replacing <p> by <br>
line 557 column 1 - Warning: inserting implicit <br>
line 557 column 1 - Warning: <br> element not empty or not closed
line 565 column 1 - Warning: <br> element not empty or not closed
line 625 column 32 - Warning: <img> element not empty or not closed
line 631 column 1 - Warning: <br> element not empty or not closed
line 635 column 1 - Warning: <br> element not empty or not closed
line 641 column 1 - Warning: missing </noscript>
line 644 column 7 - Warning: discarding unexpected </noscript>
line 646 column 1 - Warning: <br> element not empty or not closed
line 666 column 247 - Warning: unescaped & or unknown entity "&java"
line 666 column 254 - Warning: unescaped & or unknown entity "&security"
line 666 column 272 - Warning: unescaped & or unknown entity "&invisible"
line 666 column 179 - Warning: <img> element not empty or not closed
line 689 column 23 - Warning: <br> element not empty or not closed
line 699 column 1 - Warning: discarding unexpected </div>
line 707 column 179 - Warning: <img> element not empty or not closed
line 91 column 1 - Warning: <li> anchor "search" already defined
line 95 column 1 - Warning: <form> anchor "searchform" already defined
line 95 column 1 - Warning: <form> proprietary attribute "form"
line 118 column 1 - Warning: <li> anchor "pages" already defined
line 183 column 1 - Warning: <li> anchor "feeds" already defined
line 555 column 84 - Warning: <embed> escaping malformed URI reference
line 599 column 5 - Warning: <li> anchor "pages" already defined
line 600 column 113 - Warning: <img> attribute "longdesc" lacks value
line 651 column 11 - Warning: <img> lacks "alt" attribute
line 686 column 15 - Warning: <script> inserting "type" attribute
line 262 column 6 - Warning: trimming empty <p>
line 277 column 1 - Warning: trimming empty <span>
line 328 column 1 - Warning: trimming empty <span>
line 369 column 1 - Warning: trimming empty <span>
line 415 column 1 - Warning: trimming empty <span>
line 458 column 1 - Warning: trimming empty <span>
line 506 column 1 - Warning: trimming empty <span>
line 548 column 1 - Warning: trimming empty <span>
line 621 column 1 - Warning: trimming empty <p>
line 695 column 1 - Warning: trimming empty <p>

0 errors / 74 warnings

http://rcm.amazon.com/e/cm?t=archshrkcom-20&o=1&p=13&l=op1&pvid=A037F2974C028B53&ref-url=http%3A//archshrk.com/&bgc=E9E4D5&bdc=E9E4D5&pcc=969BA6&tec=636873&tic=9E9071&ac=9E9071&mp=1&hb=1&hl=1&tg=_blank&f=ifr

line 1 column 1 - Warning: inserting missing 'title' element

0 errors / 1 warning

http://pagead2.googlesyndication.com/pagead/ads?client=ca-pub-2866957639015654&dt=1161850433196&lmt=1161850419&alternate_ad_url=http%3A%2F%2Fwww.serving-sandiego.com%2Fwp-content%2Fthemes%2Ftreacle%2Famazon-160x600.html&format=160x600_as&output=html&channel=1063238416&url=http%3A%2F%2Farchshrk.com%2F&color_bg=e9e4d5&color_text=636873&color_link=969BA6&color_url=9E9071&color_border=e9e4d5&ad_type=text_image&ref=http%3A%2F%2Fdevelopers.evrsoft.com%2Fforum%2Fshowthread.php%3Ft%3D4345&cc=100&u_h=800&u_w=1280&u_ah=770&u_aw=1280&u_cd=32&u_tz=480&u_his=1&u_java=true&u_nplug=29&u_nmime=99



0 errors / 82 warnings

http://pagead2.googlesyndication.com/cpa/ads?client=ca-pub-2866957639015654&cpa_choice=CAAQ8aaVzgEaCPJg3qtkyXM9KOm293M&oe=UTF-8&dt=1161850452083&lmt=1161850419&format=468x60_as_rimg&output=html&url=http%3A%2F%2Farchshrk.com%2F&region=_google_cpa_region_&ref=http%3A%2F%2Fdevelopers.evrsoft.com%2Fforum%2Fshowthread.php%3Ft%3D4345&cc=100&u_h=800&u_w=1280&u_ah=770&u_aw=1280&u_cd=32&u_tz=480&u_his=1&u_java=true&u_nplug=29&u_nmime=99

line 1 column 1 - Warning: missing <!DOCTYPE> declaration
line 5 column 165 - Warning: unescaped & or unknown entity "&num"
line 5 column 171 - Warning: unescaped & or unknown entity "&client"
line 5 column 206 - Warning: unescaped & or unknown entity "&adurl"
line 5 column 408 - Warning: unescaped & or unknown entity "&ai"
line 5 column 763 - Warning: unescaped & or unknown entity "&ai"
line 1 column 7 - Warning: inserting missing 'title' element
line 1 column 13 - Warning: <style> inserting "type" attribute
line 2 column 120 - Warning: <script> inserting "type" attribute
line 5 column 17 - Warning: <body> proprietary attribute "leftmargin"
line 5 column 17 - Warning: <body> proprietary attribute "topmargin"
line 5 column 17 - Warning: <body> proprietary attribute "marginwidth"
line 5 column 17 - Warning: <body> proprietary attribute "marginheight"
line 5 column 702 - Warning: <img> lacks "alt" attribute

0 errors / 14 warnings