PDA

View Full Version : Kahkewistahaw First Nation


Zero Angel
11-18-2002, 12:30 PM
http://www.kahkewistahaw.com

Started out as a frames/noframes page, and was, in fact, my very first website. I later upgraded it to a very elegant PHP system (my first PHP site, in fact).

I completed the new design about 3 months ago but this is the first time that i've revealed it for public review. Can someone please review it, so that I can make improvements?

Thanks
--Zero Angel

DCElliott
11-18-2002, 01:52 PM
Nice looking site, David.

Subtle use of colors and pleasing layout. Minimal use of tables for formatting and fair separation of presentation and content.

Now the initial gripes ;)[list=1]
Watch your use of lists. You can get away with unclosed <li> tags for now but you really should close them and you *must* for xml, so start practicing. You've gotten away with it but when you have nested lists you are gonna get burned sooner or later.
I like the background image. Consider using a fixed background in your body style: body {background:url(..images.gif) no-repeat fixed 50% 50%;}
You could use the h* tags to good effect here. In a few places you have used font tags for what are heading elements - why not deal with them as headings and let the cascade take care of things. Look at the following as a possibility:
h1, h2, h3, h4, h5 {display:block; width:80%;
border-left:.5em solid #666633; border-bottom:.1em solid #666633; padding-left: .5em;
color: #444422; font-family: serif; letter-spacing: .1em;
}
I see your external stylesheet uses <style><!-- . . . etc. This is unnecessary in an external style sheet. In fact, in TopStyle, it prevents the styles from being previewed.
If you put all your nav menu links in a div called "nav" then you could have contextual selectors menu.a {. . .} for your links and you wouldn't have to have <a class="nav" . . .
[/list=1]That's it for now - if it weren't already a great page, I would have saved my breath!

Zero Angel
11-18-2002, 02:10 PM
Yeah, some of it is based on older code that I wrote a few months after I learned HTML. I learned about contextual selectors later on, and I guess theres no need to change something that already works.

As far as the H tags go, i'll have to start using those from now on, it would be a lot simpler then writing <div class="pgheading">stuff</div>

Closing list items is something that i'll definitely take into consideration if I have to recode the site. External CSS is something that i'll do immediately.

The fixed background image could be a problem, though. I want it centered with the 'content' cell, but if I center it with the BODY, it means that it'll look akward and slightly to the left because of the TOC cell.

Thanks David! ;)

DCElliott
11-18-2002, 02:49 PM
For the background you could play around with the amount of top and left offset of the image, increasing the left offset to 60-65%. Its a nice background and I'd like to see you try to get a watermark effect.